Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing dataset references #3873

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Fixing dataset references #3873

merged 4 commits into from
Jul 31, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 27, 2023 •
edited
Loading

Closes #3871

Description Of Changes

Adding conversions between dataset reference objects and dataset reference strings to the front-end.

Code Changes

  • Added conversions between dataset reference objects and dataset reference strings to the front-end.
  • Fixed minor bug in the mask_sensitive_fields function

Steps to Confirm

  • Create a System with a Postgres connection and a minimal dataset just containing a user collection with a single ID field
  • Create a Doordash system
  • Add a Doordash integration and set the value of Doordash Delivery ID to be the dataset created in step one, for example shop.customers.id
  • Navigate to the System Management page, results should be returned
  • Navigate directly to the Doordash system (for example: http://localhost:3000/systems/configure/doordash)
  • Verify the Doordash Delivery ID is set to shop.customers.id

Pre-Merge Checklist

@galvana galvana linked an issue Jul 27, 2023 that may be closed by this pull request
Connector forms with dataset references do not work as expected #3871
Closed
@cypress
Copy link

cypress bot commented Jul 27, 2023 •
edited
Loading

Passing run #3406 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3be38b3 into f6eedab...
Project: fides Commit: 3b5ed40855 ℹ️
Status: Passed Duration: 00:49 💡
Started: Jul 31, 2023 4:03 PM Ended: Jul 31, 2023 4:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (f6eedab) 87.18% compared to head (3be38b3) 87.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3873      +/-   ##
==========================================
+ Coverage   87.18%   87.19%   +0.01%     
==========================================
  Files         317      317              
  Lines       19350    19352       +2     
  Branches     2485     2486       +1     
==========================================
+ Hits        16870    16874       +4     
+ Misses       2049     2048       -1     
+ Partials      431      430       -1
Files Changed Coverage Δ
src/fides/api/api/v1/endpoints/system.py 78.35% <100.00%> (ø)
...emas/connection_configuration/connection_config.py 100.00% <100.00%> (+2.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TheAndrewJackson
TheAndrewJackson approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

src/fides/api/schemas/connection_configuration/connection_config.py Show resolved Hide resolved
@galvana galvana merged commit ed168b3 into main Jul 31, 2023
@galvana galvana deleted the 3871-fix-dataset-references branch July 31, 2023 17:27
SteveDMurphy pushed a commit that referenced this pull request Aug 3, 2023
@galvana @SteveDMurphy
Fixing dataset references (#3873)
9b418b6
@SteveDMurphy SteveDMurphy mentioned this pull request Aug 3, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connector forms with dataset references do not work as expected
2 participants
@galvana @TheAndrewJackson